Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Nested Category Screen #1792

Open
wolfsolver opened this issue Aug 25, 2024 · 3 comments · Fixed by #1942
Open

New Nested Category Screen #1792

wolfsolver opened this issue Aug 25, 2024 · 3 comments · Fixed by #1942
Assignees
Labels

Comments

@wolfsolver
Copy link
Contributor

I made some check and develop a mockup for multilevel category entry..

image

Comment on Usability are welcome

@wolfsolver
Copy link
Contributor Author

wolfsolver commented Aug 27, 2024

Here a simple idea.

https://github.com/wolfsolver/exampleNestedCategory

@guanlisheng did you have any suggestions?

First switch off use method like previous one, set on use _self to handle parent as children (so parent can have total)
Second switch show selection view vs report view

screen-20240827-180826.gif

@wolfsolver
Copy link
Contributor Author

@guanlisheng I need your support to convert from sample project into AMMEX. Take a look to my latest deploy on https://github.com/wolfsolver/exampleNestedCategory

I try to adapt sample code into AMMEX structure. Previus category management use this this kind of declaration

public class CategoryListFragment
    extends BaseExpandableListFragment
    implements LoaderManager.LoaderCallbacks<Cursor> 

and the following hierarchy: BaseExpandableListFragment --> ExpandableListFragment --> Fragment

I need to switch from ExpandableList to new layout based on two piece of layout:

  • data_activity.xml (need to be renamed with NestedCategoryFragment ==> This has the adapter binded
  • item_activity.xml (need to be renamed with NestedCategoryItemFragment ==> where layout is define with convertView = LayoutInflater.from(DataActivityComplex.this).inflate(R.layout.data_item, null);

This suggest to have this new class inside project:

  • NestedCategoryListFragmentNew extends BaseMultiLevelListFragment implements LoaderManager.LoaderCallbacks<Cursor>
  • BaseMultiLevelListFragment extends BaseListFragment

and put all logic for generic multilevel into BaseMultiLevelListFragment and all specifc logic into NestedCategoryListFragmentNew

It's correct? do you have any suggestion?

@wolfsolver
Copy link
Contributor Author

wolfsolver commented Dec 1, 2024

My Todo list:

  • force always use of new model
  • delete unused code where used by getUseNestedCategory() remove also if
  • substitute reference of QueryCategorySubCategory with new QueryNestedCategory
  • remove unnecessary field subcategory in some method (or replace with null)
  • remove unnecessary files
  • remove switch from preference
  • remove unrelevant subcategory field from all query

@wolfsolver wolfsolver reopened this Dec 1, 2024
wolfsolver added a commit that referenced this issue Dec 1, 2024
Step 2 for remove unused code #1792
@wolfsolver wolfsolver pinned this issue Dec 1, 2024
@wolfsolver wolfsolver unpinned this issue Dec 1, 2024
wolfsolver added a commit that referenced this issue Dec 3, 2024
Step 3a prepare for remove unused code #1792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant