From e31da5f62b29a3c2f660397199be9e92809f735d Mon Sep 17 00:00:00 2001
From: Lisheng Guan <guanlisheng@gmail.com>
Date: Sat, 28 Dec 2024 18:14:33 +0800
Subject: [PATCH] Widget: permission and flag fix

---
 app/src/main/AndroidManifest.xml                     |  4 ++--
 .../manager/ex/datalayer/AccountRepository.java      |  1 -
 .../money/manager/ex/widget/SingleAccountWidget.java | 12 +++++-------
 3 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 28a0cf74e..c8d75d163 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -360,7 +360,7 @@
         <provider
             android:name=".MmxContentProvider"
             android:authorities="${applicationId}.provider"
-            android:exported="false" />
+            android:exported="true" />
         <!-- used for qif export -->
         <provider
             android:name="androidx.core.content.FileProvider"
@@ -382,7 +382,7 @@
 
         <service
             android:name=".widget.AccountBillsWidgetService"
-            android:permission="android.permission.BIND_JOB_SERVICE" />
+            android:permission="android.permission.BIND_REMOTEVIEWS" />
         <service
             android:name=".sync.SyncService"
             android:exported="false"
diff --git a/app/src/main/java/com/money/manager/ex/datalayer/AccountRepository.java b/app/src/main/java/com/money/manager/ex/datalayer/AccountRepository.java
index a3a8be3f9..3f2ea0aaf 100644
--- a/app/src/main/java/com/money/manager/ex/datalayer/AccountRepository.java
+++ b/app/src/main/java/com/money/manager/ex/datalayer/AccountRepository.java
@@ -202,5 +202,4 @@ private Account insert(Account entity) {
 
         return entity;
     }
-
 }
diff --git a/app/src/main/java/com/money/manager/ex/widget/SingleAccountWidget.java b/app/src/main/java/com/money/manager/ex/widget/SingleAccountWidget.java
index 662bfe71f..28b7f9eca 100644
--- a/app/src/main/java/com/money/manager/ex/widget/SingleAccountWidget.java
+++ b/app/src/main/java/com/money/manager/ex/widget/SingleAccountWidget.java
@@ -68,18 +68,16 @@ private static long getCellsForSize(long size) {
     @Override
     public void onUpdate(Context context, AppWidgetManager appWidgetManager, int[] appWidgetIds) {
         // There may be multiple widgets active, so update all of them
-        final long N = appWidgetIds.length;
-        for (int i = 0; i < N; i++) {
-            updateAppWidget(context, appWidgetManager, appWidgetIds[i]);
+        for (int appWidgetId : appWidgetIds) {
+            updateAppWidget(context, appWidgetManager, appWidgetId);
         }
     }
 
     @Override
     public void onDeleted(Context context, int[] appWidgetIds) {
         // When the user deletes the widget, delete the preference associated with it.
-        final long N = appWidgetIds.length;
-        for (int i = 0; i < N; i++) {
-            SingleAccountWidgetConfigureActivity.deleteTitlePref(context, appWidgetIds[i]);
+        for (int appWidgetId : appWidgetIds) {
+            SingleAccountWidgetConfigureActivity.deleteTitlePref(context, appWidgetId);
         }
     }
 
@@ -260,7 +258,7 @@ private void initializeRefreshDataCommand(Context context, RemoteViews views, in
         intent.setAction(AppWidgetManager.ACTION_APPWIDGET_UPDATE);
         intent.putExtra(AppWidgetManager.EXTRA_APPWIDGET_IDS, new int[]{appWidgetId});
         PendingIntent pendingIntent = PendingIntent.getBroadcast(context,
-                0, intent, PendingIntent.FLAG_UPDATE_CURRENT);
+                0, intent, PendingIntent.FLAG_UPDATE_CURRENT | PendingIntent.FLAG_IMMUTABLE);
 
         views.setOnClickPendingIntent(R.id.refreshDataPanel, pendingIntent);
     }