Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address cases of multiple gene associations #8330

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Address cases of multiple gene associations #8330

merged 4 commits into from
Nov 21, 2024

Conversation

twhetzel
Copy link
Collaborator

closes #8329

Please see ticket for explanation of changes

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twhetzel
I think retinitis pigmentosa 7 should not have association with any genes. Please see my explanation in the comment. I can make the changes if you want, but I first want to make sure you have a chance you check my explanation in case you don't disagree.

@@ -271426,6 +271422,7 @@ is_a: MONDO:1040055 {source="https://clinicalgenome.org/working-groups/clinical-
intersection_of: MONDO:0019200 ! retinitis pigmentosa
intersection_of: has_material_basis_in_germline_mutation_in http://identifiers.org/hgnc/10254 ! ROM1
intersection_of: has_material_basis_in_germline_mutation_in http://identifiers.org/hgnc/9942 ! PRPH2
relationship: excluded_from_qc_check http://purl.obolibrary.org/obo/mondo/sparql/qc/mondo/qc-multiple-gene-associations.sparql
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct.
According to OMIM, this record refers to the disease for which the RDS gene (PRPH2) is mutated, however, "A digenic form of retinitis pigmentosa resulting from a mutation in the RDS gene (179605.0004) and a null mutation of the ROM1 gene (see 180721.0001) has been reported."

Therefore, for this record, we cannot say that in 100% of the case, the disease is caused by a mutation in both genes (or in a mutation in only one gene).

The gene annotations should be removed for this disease.

Note: the definition for this disease should also be changed to make this disease concept not specific to the mutation in the PRPH2 gene.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sabrina. I agree and will make the changes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@sabrinatoro sabrinatoro assigned twhetzel and unassigned sabrinatoro Nov 13, 2024
@twhetzel twhetzel assigned sabrinatoro and unassigned twhetzel Nov 13, 2024
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twhetzel I updated the definition for retinitis pigmentosa 7.
I think this PR can be merged after QC have passed.

OMIM:608133 indicates that there are 2 included entries. We should add these with the "omim included" x-ref in a different PR (note, i have not created an issue for this).

From Trish - ticket added #8424

@sabrinatoro sabrinatoro assigned twhetzel and unassigned sabrinatoro Nov 14, 2024
@twhetzel twhetzel merged commit b806fde into master Nov 21, 2024
1 check passed
@twhetzel twhetzel deleted the issue-8329 branch November 21, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to fix QC errors for multiple gene associations
2 participants