Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsatisfiable class in Mondo #8429

Closed
matentzn opened this issue Nov 21, 2024 · 5 comments
Closed

Unsatisfiable class in Mondo #8429

matentzn opened this issue Nov 21, 2024 · 5 comments
Assignees

Comments

@matentzn
Copy link
Member

matentzn commented Nov 21, 2024

When refreshing the OMIM gene relations (#8108) we noticed the following unsat.

This will be fun to crack! QC fail: https://github.com/monarch-initiative/mondo/actions/runs/11962410332/job/33350758622

osteopetrosis, autosomal dominant 3 SubClassOf Nothing

paroxysmal nocturnal hemoglobinuria 1 SubClassOf Nothing

Ontologies used:

@twhetzel
Copy link
Collaborator

Only MONDO:0020848 remains as an issue. Due to a bug in the omim ingest pipeline and/or lack information in an omim file, a gene association was added to MONDO:0010438 saying it was germline, when it already had somatic.

@twhetzel
Copy link
Collaborator

twhetzel commented Nov 22, 2024

Related to the QC check error (Unsatisfiable) for MONDO_0020848, Nico pointed this out:

Based on https://omim.org/entry/611497, MONDO:0012679 'autosomal recessive osteopetrosis 6' has a gene association with evidence from medgen that does not meet our criteria for disease defining gene associations (the phenotype label displayed in omim is prefixed with a special character, e.g. ?) we add from omim. However, other sources like ClinGen include both of these diseases caused by this gene.

@sabrinatoro can you advise how to resolve this issue?

@twhetzel
Copy link
Collaborator

I removed the gene association from MONDO:0012679 'autosomal recessive osteopetrosis 6' since this does not meet our rules for adding gene associations based on OMIM data and for now we need to move forward on the Tech side based on discussions with @matentzn. If this is not the right decision from a curation perspective, that needs to be addressed later.

@twhetzel twhetzel assigned sabrinatoro and unassigned twhetzel Nov 22, 2024
@matentzn
Copy link
Member Author

FWIW I agree with the change for now, here it is for reference:

da20096#diff-889e0a9ba62d62cc6ee7c5c9bead0075444d506253590ef0dcf4786904ac6768L288824

@twhetzel
Copy link
Collaborator

These changes were included in #8108 so this ticket is also closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants