Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gene mapping suggestions #20

Open
matentzn opened this issue Jul 13, 2023 · 10 comments
Open

Gene mapping suggestions #20

matentzn opened this issue Jul 13, 2023 · 10 comments
Assignees

Comments

@matentzn
Copy link
Member

  1. Add mapping_source field with a reference to the original file used
  2. Add mapping_source_version field with some kind of indication when it was used
@glass-ships
Copy link
Contributor

Are you looking to add these as fields in the registry.yaml? I'm not sure I follow

@matentzn
Copy link
Member Author

No at the SSSOM file you created in the gene mappings pipeline! Maybe it was @kevinschaper

@kevinschaper kevinschaper self-assigned this Jul 13, 2023
@glass-ships
Copy link
Contributor

Gotcha, thanks @matentzn
I've got a branch ready for this but it looks like I still don't have permissions to create a PR

@matentzn
Copy link
Member Author

Seem you have write rights here: https://github.com/monarch-initiative/monarch-gene-mapping, isn't that what is needed?

@glass-ships
Copy link
Contributor

ahhh, no the script we added is in this repository

@matentzn
Copy link
Member Author

Even here (https://github.com/monarch-initiative/monarch-mapping-commons) you seem to already have write access!

@glass-ships
Copy link
Contributor

omg i totally do, it's cuz i had the url in my git config as https instead of ssh.
apologies! making the PR now

@glass-ships
Copy link
Contributor

was this closed by the merged PR?

@matentzn
Copy link
Member Author

Is the first comment #20 (comment) addressed?

@glass-ships
Copy link
Contributor

ah no i suppose not. it is for biomappings, but not gene mapping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants