WIP partial_sheet_signatures.js #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing duplex/single sheet saving logic, adding 1/3rd page layout
* start contributor docs, add build script * add links to resources * continue contribution guide * add PR screenshot * move extra help steps to separate doc * typo fix Co-authored-by: Devon Wolfkiel <[email protected]>
* move theme colors to variables, add dark mode media query * adjust color of text on disabled buttons and dropdowns to have better contract in dark mode * soften colors and adjust link colors * adjust styling to be more responsive * add wrapper and viewport tag to old page * remove unneeded attribute Co-authored-by: Devon Wolfkiel <[email protected]>
* Add tests * Updating contributing doc with info on tests * Refactor preload.js into smaller components * Move constants to separate file * General code tidying Co-authored-by: jackal-ate-jill <[email protected]>
…omijizukamori#15) * broken... but so close to new layout * :( y u no build? * 3 6s now working * fixing some things * pretty happy with all that now * aaaaand another layout * aaaaand another layout * ok, final changes for UI cleanup * fix 16 per side lines * tweaking display names
Gaaaaahhhh... fixing bad break for the mini layout (landing because it's just a minor fix in just the wacky layouts)
…fixes problem encountered on 1/3rd layout at least
…ank_pages_fix minor bandaid for wacky all-blank pages (Merging because this only affects the wacky code & is a minor bug fix)
…more than one signature
One PDF To Rule Them All
adding some helpful info based on Discord discussions
Should work for eg all signatures 5 pieces of paper to sew. Can't remember if I managed to get it to work with uneven signatures (eg equivalent of 6,5,5,6 on folio)
added at lines 165-172 and 186
sithel
reviewed
Oct 7, 2022
| @@ -161,6 +161,14 @@ export class Book { | |||
| this.rearrangedpages = this.book.pagelist; | |||
| } else if (this.format == 'a9_3_3_4' || this.format == 'a10_6_10s' || this.format == 'A7_2_16s' || this.format == '1_3rd' || this.format == 'a_3_6s' || this.format == 'a_4_8s') { | |||
| this.book = new WackyImposition(this.orderedpages, this.duplex, this.format, this.pack_pages) | |||
| } else if (this.format == 'partsheetsigstandard' || this.format =='partsheetsigcustom') { | |||
There was a problem hiding this comment.
you introduce this format partsheetsigstandard and partsheetsigcustom but there's still no way for that to be selected...
sithel
reviewed
Oct 7, 2022
| @@ -161,6 +161,14 @@ export class Book { | |||
| this.rearrangedpages = this.book.pagelist; | |||
| } else if (this.format == 'a9_3_3_4' || this.format == 'a10_6_10s' || this.format == 'A7_2_16s' || this.format == '1_3rd' || this.format == 'a_3_6s' || this.format == 'a_4_8s') { | |||
| this.book = new WackyImposition(this.orderedpages, this.duplex, this.format, this.pack_pages) | |||
| } else if (this.format == 'partsheetsigstandard' || this.format =='partsheetsigcustom') { | |||
| this.book = new PartialSheetSignatures(this.orderedpages, this.duplex, this.sigsize, this.per_sheet, this.duplexrotate); | |||
There was a problem hiding this comment.
missing the import for this at the top
import { PartialSheetSignatures } from './partial_sheet_signatures.js';
sithel
reviewed
Oct 7, 2022
src/partial_sheet_signatures.js
Outdated
| @@ -0,0 +1,128 @@ | |||
| import {Booklet} from './booklet.js'; | |||
|
|
|||
| export class PartialSheetSignatures { | |||
There was a problem hiding this comment.
I did a test export of this and the zip downloaded was empty-- does this work for you locally?
Lottie16
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should work for eg all signatures 5 pieces of paper to sew.
Can't remember if I managed to get it to work with uneven signatures (eg equivalent of 6,5,5,6 on folio)
@sithel tagging you as requested :D