Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to open *.cif, *.CIF, *.MMCIF, *.mmCIF #16

Open
tinchogb opened this issue Nov 3, 2022 · 3 comments
Open

Fails to open *.cif, *.CIF, *.MMCIF, *.mmCIF #16

tinchogb opened this issue Nov 3, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tinchogb
Copy link

tinchogb commented Nov 3, 2022

Hi 👋🏼 , thanks for this amazing extension.

I was trying to open it from local files structures and...

Fails when I choose:

*.cif
*.CIF
*.MMCIF
*.mmCIF

but not with:

*.mmcif

Extension: Protein Viewer
Version: v0.0.8
OS: Ubuntu 22.04
Visual Studio Code:
Version: 1.72.2
Commit: d045a5eda657f4d7b676dedbfa7aab8207f8a075
Date: 2022-10-12T22:16:26.920Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Linux x64 5.15.0-52-generic
Sandboxed: No

@a-r-j a-r-j mentioned this issue Nov 13, 2022
a-r-j added a commit that referenced this issue Nov 13, 2022
* add support for .cif .CIF .MMCIF .mmCIF #16

* add ESMFold Support

* add version string

* update changelog
a-r-j added a commit that referenced this issue Nov 13, 2022
* add support for .cif .CIF .MMCIF .mmCIF #16

* add ESMFold Support

* add version string

* update changelog

* update readme

* add fix to ensure extensions are lowercase
@a-r-j a-r-j added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 5, 2023
@MarcoVando
Copy link

Same here.
What type of commands are needed in cif files?
Some programs during structure solution/refinement usually export only atom positions and symmetry operations. Are these cif command sufficient?

@a-r-j
Copy link
Collaborator

a-r-j commented May 10, 2023

Hmm, I was under the impression that I’d fixed this:

"when": "resourceExtname == .pdb || resourceExtname == .pdb.gz || resourceExtname == .PDB || resourceExtname == .mol2 || resourceExtname == .MOL2 || resourceExtname == .sdf || resourceExtname == .SDF || resourceExtname == .mmCIF || resourceExtname == .mmcif || resourceExtname == .cif.gz || resourceExtname == .MMCIF || resourceExtname == .Mol || resourceExtname == .mol || resourceExtname == .MOL || resourceExtname == .xyz || resourceExtname == .XYZ || resourceExtname == .ent || resourceExtname == .ENT || resourceExtname == .pdbqt || resourceExtname == .PDBQT || resourceExtname == .cif || resourceExtname == .CIF || resourceExtname == .mcif || resourceExtname == .MCIF || resourceExtname == .gro || resourceExtname == .GRO",

It also doesn’t work for me though. I’m not going to have bandwidth to work on this for the foreseeable future so I’m hoping someone would be able to pick this up. Happy to support.

On a second look, it could be this line needs to be updated:

if (extension === 'cif' || extension === 'mmCIF' || extension === 'CIF' || extension === 'MMCIF' || extension == '.mCIF' || extension == '.mcif') {

@MarcoVando
Copy link

Same problem
What are the minimum needed commands that need to be in the .cif file? I use a software that generate very basic .cif files from refining process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants