Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShipmentShipEventListener session var is never initialised or passed to the service #37

Open
ofinsterbusch opened this issue Nov 21, 2024 · 2 comments

Comments

@ofinsterbusch
Copy link

Hey,

In \SyliusMolliePlugin\EventListener\ShipmentShipEventListener the $session var is never initialised or pass in the service/constructor so if there is an error calling Mollie API the catch will fail as $this->session is null

@ofinsterbusch
Copy link
Author

I've temporary fixed this decorating the service and duplicating that class to add the RequestStack to get the session as Symfony recommends

@logeecom
Copy link
Contributor

logeecom commented Dec 2, 2024

Hello @ofinsterbusch,

Please note that our team fixed the issue in this PR: #40

After it is merged, our team will release a new plugin version.

Thank you,

Kind regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants