Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: ES2015 module resolution support #35

Closed
trevordmiller opened this issue Sep 4, 2016 · 10 comments · May be fixed by #47
Closed

Feature request: ES2015 module resolution support #35

trevordmiller opened this issue Sep 4, 2016 · 10 comments · May be fixed by #47

Comments

@trevordmiller
Copy link

trevordmiller commented Sep 4, 2016

I was looking for a plugin that would let me use gf with both node require() and ES2015 import syntax; this plugin solved 3 of 4 situations:

  • ✔ Relative Node modules: const someModule = require('./someModule')
  • ✔ Resolved Node modules: const someModule = require('someModule')
  • ✔ Relative ES2015 modules: import someModule from './someModule'
  • 🙏 Resolved ES2015 modules: import someModule from 'someModule'

Because ES2015 modules are gaining greater popularity and are being considered for Node itself, it would be awesome if this plugin covered the fourth situation as well. To go along with this, this plugin could potentially be re-named to vim-es-modules or something...

p.s. Great plugin! Thank you for making it :)

@moll
Copy link
Owner

moll commented Nov 14, 2016

Hey,

A short answer would be: Should probably add ES2015 modules here, too, indeed. ;)

@moll moll reopened this Nov 14, 2016
@moll
Copy link
Owner

moll commented Mar 15, 2017

Oh, don't worry about that. 4 months in the OSS world is nothing. We're all doing this on our free time and aside from show-stopping bugs, life takes precedence over features. :) We'll get around to this, too. ;)

@moll moll reopened this Mar 15, 2017
@trevordmiller
Copy link
Author

I understand, I'm an open source author as well :) But I'm going to close this since it has been another 10 months since the issue was first opened and I have moved on to another plugin and would like to tidy up my open issues.

@moll
Copy link
Owner

moll commented Jun 25, 2017

Ah, would you unsubscribing from this solve your orderliness desire with my keeping-it-around-until-I-get-to-it desire? :)

@trevordmiller trevordmiller reopened this Jun 25, 2017
@agriffis
Copy link

agriffis commented Aug 6, 2018

@trevordmiller You mentioned that you moved on to another plugin. Mind saying what that is?

@trevordmiller
Copy link
Author

@agriffis I'm not sure which plugin under the hood handles it, but since installing vim-polyglot and latest Vim (8+), using gf over import someModule from 'someModule' works for me :) https://github.com/trevordmiller/dotfiles/blob/master/files/.vimrc

@trevordmiller
Copy link
Author

trevordmiller commented Aug 24, 2018

It's been almost two years since this issue was created. Closing this as I don't use the plugin anymore and am clearing out old issues. If you want it re-opened, please make a new issue. Thanks.

@moll
Copy link
Owner

moll commented Aug 24, 2018

Doesn't time fly. :) You're welcome to unsubscribe from this issue if you don't want to be notified, but I'd like to keep it open as it's a perfectly valid desire.

@moll moll reopened this Aug 24, 2018
@trevordmiller
Copy link
Author

trevordmiller commented Aug 24, 2018

@moll I use the "Issues" feature of GitHub to keep track of the issues I'm involved with which shows issues you have created, even when unsubscribed. Please stop reopening the issue. Feel free to create a new one if you'd like it.

@moll
Copy link
Owner

moll commented Aug 24, 2018

Hmm, I don't want to create another issue for this, but I also don't want you to be have to see it. I wonder how we could report this as a bug to GitHub...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants