Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quoting-service: json-rules-engine upgrade to address deprecation #4023

Open
11 tasks done
elnyry-sam-k opened this issue Dec 17, 2024 · 0 comments
Open
11 tasks done
Assignees
Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story

Comments

@elnyry-sam-k
Copy link
Member

elnyry-sam-k commented Dec 17, 2024

Goal:

As a maintainer of the Mojaloop OSS codebase

I want to ensure the quoting-service is up-to-date

so that any underlying (nested) deprecations are identified and addressed; this story is specific to json-rules-engine dependency

Acceptance Criteria:

  • json-rules-engine dependency is upgraded and all tests passing

Complexity: Medium

Uncertainty: High


Tasks:

  • Identify fixes and implement
  • troulbeshoot and root cause unit tests for
  • Add 2 new custom operators to json-rules-engine arrayEqual and arrayNotEqual for backward compatibility as after updates jsonpath-plus in combination to almanac.js setting of wrap:false returns an array instead of a scalar when there is only 1 element in the result.

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

Follow-up:

  • The PR-377 is open against the minor/iso branch, to make it to main it needs to be merged into minor/iso and then to main.

Dependencies:

  • N/A

Accountability:

  • Owner: Juan Correa
  • QA/Review: TBC
@elnyry-sam-k elnyry-sam-k added story oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story
Projects
None yet
Development

No branches or pull requests

2 participants