Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Quoting Service into an event driven solution to improve performance #3666

Closed
14 of 24 tasks
PaulGregoryBaker opened this issue Nov 28, 2023 · 2 comments
Closed
14 of 24 tasks

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Nov 28, 2023

Goal:

As a Mojaloop Community member
I want to have a performant quoting service
so that I can scale the quoting servce

Note: The current quote service performs this action in memory, and a better solution would be to split the servce into two microservices with Kafka events. This will decouple the participant API responses from the work being perfromed and free's up the nodeJS event loop.

Private Zenhub Image

Acceptance Criteria:

  • Verify the Quote service is split into two microservices namely an quotes API service and and quotes handler service
  • Verify that a configurable kafka topic is used to pass messages between the servcies (kafka configuration should follow same pattern as central ledger)
  • Verify that the GP test pass
  • Verfy that there is a new runtime CLI option (using commander lib; same as central ledger)
  • Verfy that a health endpoint is added to the new servces

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@PaulGregoryBaker PaulGregoryBaker added core-dev-squad story to-be-refined This story is ready to be groomed labels Nov 28, 2023
@PaulGregoryBaker
Copy link
Author

@PaulGregoryBaker PaulGregoryBaker added PI-23 and removed to-be-refined This story is ready to be groomed labels Dec 4, 2023
@geka-evk geka-evk self-assigned this Dec 5, 2023
@elnyry-sam-k
Copy link
Member

@PaulGregoryBaker and @geka-evk , thanks for this issue. Please bring this up at the DA at the earliest; I'm not opposed to this and it makes sense but it is a significant change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants