Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad video performance #205

Open
drwankingstein opened this issue Aug 22, 2024 · 5 comments
Open

Bad video performance #205

drwankingstein opened this issue Aug 22, 2024 · 5 comments

Comments

@drwankingstein
Copy link

Video performance with MPV is quite poor. It seems to default to hwdec=mediacodec-copy Setting hwdec=mediacodec made it perform better, however looping seemed to have broken.

On low end devices, setting profile=fast also can help. I have also had the app stop responding and need to be closed and re-opened.

Also is it possible to provide builds with impeller enabled and disabled respectively? It might also help performance some, but some devices have bad vulkan drivers and they might be negatively effected.

@moffatman
Copy link
Owner

Impeller text rendering is trash I won't be using it
For mpv, so you tried some of your own options in-app? or recompiled? I could change the defaults....

@drwankingstein
Copy link
Author

I tried them in app. MPV fast profile is here https://github.com/mpv-player/mpv/blob/92f052c14e994b7ea77dc370b01bed5f8ef546db/etc/builtin.conf#L43

Some of these wont apply because media-kit seems to be using libmpv and not vo=gpu, but I still found it to help some.

The major thing is hwdec=mediacodec which prevents the memory copy which will remove stutter on low end devices. For some reason the looping is broken so that would likely need fixed first. I did try loop=inf in the settings but it did nothing.

@moffatman
Copy link
Owner

I am not sure if it's fixable. Especially since I don't have such a device to work on this at all. My Android phone works well.

mpv-android/mpv-android#147

@idontveapc
Copy link

Video loop is already not perfect. Sometime some of the videos stop just a sec before to loop, or maybe they play once. But time seeker shows 1 sec remaining.

@moffatman
Copy link
Owner

There was some other bug for some time where the duration in the controls was for the wrong video. so it looked like it was looping too early, but really was playing properly. Other looping issues seem to be resolved by setting hwdec=no. So I dont' think I can make much progress on them as it's device-specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants