Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientConfig type ACE #180

Open
OlegShchavelev opened this issue Feb 22, 2020 · 7 comments
Open

ClientConfig type ACE #180

OlegShchavelev opened this issue Feb 22, 2020 · 7 comments

Comments

@OlegShchavelev
Copy link

Hello, Mark

When changing the type of the field from textarea to ace, the application simply stopped working. I show in the screenshot.

изображение

I show the ACE package of the latest version in the screenshot

изображение

ACE Settings

изображение

изображение

https://i.imgur.com/odhKlQv.png
изображение

Environment

ClientConfig 2.3.0 , MODX 2.7.2 и PHP 7.2.25

@sebastian-marinescu
Copy link
Contributor

Hi @OlegShchavelev just curious: did you fix it or find out what the problem was?

@Ruslan-Aleev
Copy link
Contributor

Yep, I'm confirming bug. But problem in Ace:

focus_1
focus_2

@sebastian-marinescu
Copy link
Contributor

Hi @Ruslan-Aleev, what versions are you running?

Because I cannot confirm it with either:
MODX 2.8.5-pl, Ace 1.9.3-pl, ClientConfig 2.3.3-pl
nor with:
MODX 3.0.2-pl, Ace 1.9.3-pl, ClientConfig 2.3.0-pl

Both are working for me:

image

@sebastian-marinescu
Copy link
Contributor

Maybe it needs the system-setting to be also set to Ace?

image

@Ruslan-Aleev
Copy link
Contributor

@sebastian-marinescu Hi!
It's really weird =)
I took up the question, since the problem was reported in the telegram chat, I checked the ClientConfig and the problem also happened to me.

I have: MODX 2.8.5-pl, Ace 1.9.3-pl (but Ace installed from modstore.pro), ClientConfig 2.3.3-pl

image

Not only that, I even found a solution =) but now it's not clear why you don't have a problem...

Solution:
in /assets/components/ace/modx.texteditor.js somewhere near the line 232, replace the code with:

focus: function (){
    this.valueHolder.focus();
},

@Ruslan-Aleev
Copy link
Contributor

Ruslan-Aleev commented Jul 22, 2023

@sebastian-marinescu I installed clean MODX with git, did not do any MODX settings, I installed only 2 components Ace and ClientConfig from the modx.com repository.
I created a group and a code-setting in ClientConfig - the problem is reproduced (checked in the latest Google Chrome, in incognito mode) ...

@Ruslan-Aleev
Copy link
Contributor

Ruslan-Aleev commented Jul 24, 2023

@sebastian-marinescu So it looks like we've found a way to reproduce the bug - make the ace-setting first in the group; refresh the page and ClientConfig section will crash with an error in the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants