Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage examples #31

Open
qbit- opened this issue Jul 5, 2021 · 4 comments
Open

Usage examples #31

qbit- opened this issue Jul 5, 2021 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@qbit-
Copy link

qbit- commented Jul 5, 2021

Thanks for the great effort of bringing NUFFT to Pytorch!
The current version of the code is geared towards image analysis, and MRI specifically.
As such, it is hard to grasp the meaning of arguments and their names from the examples.
It would be great to have a basic 1D example of forward/inverse NUFFT-I/NUFFT-II to broaden user
audience

@mmuckley
Copy link
Owner

mmuckley commented Jul 6, 2021

Great idea - do you have a specific example that might be useful for people executing 1D NUFFTs? If not, I could just throw something elementary together.

@qbit-
Copy link
Author

qbit- commented Jul 26, 2021

I'm experimenting with audio processing, the entire example is pretty complicated to describe it in full. It would be helpful to have something like the examples on the finufft page here:
minimal interface and the mathematical description of what it does.
By the way, which definition of the NUFFT torchkbnufft supports?

@mmuckley mmuckley added enhancement New feature or request help wanted Extra attention is needed labels Feb 14, 2022
@kylematoba
Copy link

A good self-contained example would be to reconcile against the PyTorch fft module. E.g. check that interpolated points are close to the exact value computed over a finer grid.

@mmuckley
Copy link
Owner

mmuckley commented Jul 5, 2022

To me this sounds great @kylematoba - just don't have time to implement it right now myself due to other projects... If you open a PR would be happy to consider it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants