Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: skgstat.Variogram: After scipy update from 1.11.1 to 1.11.2: Optimal parameters not found #161

Closed
ekloberdanz opened this issue Aug 18, 2023 · 6 comments · Fixed by #175
Assignees
Labels

Comments

@ekloberdanz
Copy link

After the release of scipy 1.11.2 skgstat.Variogram begun to throw RuntimeError: Optimal parameters not found: The maximum number of function evaluations is exceeded.

@mmaelicke
Copy link
Owner

Thanks for reporting, I am on vacation next week and will look into this right after, as soon as possible.

Best,
Mirko

@mmaelicke mmaelicke self-assigned this Aug 18, 2023
@mmaelicke mmaelicke added the bug label Aug 18, 2023
@mmaelicke
Copy link
Owner

I am struggling to reproduce the error. Can you give me some more info? Do you experience the bug with any kind of parameters, or just a specific instance?
Especially, the exact Python version and maybe upload a csv containing some sample data and a minimal example.

From the scipy release notes, I can only find one issue that is related to the scipy.optimize module (scipy/scipy#18793). Right now, although being relevant for SciKit-GStat, I cannot see how this bugfix could cause the reported error.

Do you by any chance use Python 3.11? I am a bit behind in terms of testing and have neither updated the CI to test against Python 3.11, nor am I using it any of my code pipelines. If so, this might be a good opportunity to catch up.

@rhugonnet
Copy link
Contributor

Maybe related to the new CI errors we get since a week or so, looks like it's only Python 3.9 and 3.10: #162

@rhugonnet
Copy link
Contributor

Indeed, a bug was introduced in 1.11.2 when trying to fix scipy/scipy#18793.
They're on it: scipy/scipy#19103

@rhugonnet
Copy link
Contributor

Still not fixed for all cases with 1.11.3, as we saw in #160.
I opened an issue with a reproducible example: scipy/scipy#19351

@rhugonnet
Copy link
Contributor

This bug has been fixed in SciPy, now works with 1.11.4. We can close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants