Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a transpiled version (or older version) without ES5 code? #69

Open
zyxue opened this issue Jun 4, 2017 · 2 comments
Open

Is there a transpiled version (or older version) without ES5 code? #69

zyxue opened this issue Jun 4, 2017 · 2 comments

Comments

@zyxue
Copy link

zyxue commented Jun 4, 2017

I am using this library with create-react-app, but it causes a problem when I tried to compile my code into a production build, because uglifyjs in used by create-react-app doesn't work with ES5 code. See more discussion on

facebook/create-react-app#1125

Until then I recommend to use libraries that take care of transpilation step.

I am mainly looking at the Matrix and PCA functionality currently.

Or if you have idea on transpilation (e.g. with babel), please provide some guidance, and I could try it myself.

@targos
Copy link
Member

targos commented Jun 7, 2017

I don't use create-react-app but if you can play with the webpack config, I suggest you to replace uglifyjs with babili. That's what we use to minify our applications.
https://github.com/webpack-contrib/babili-webpack-plugin

@zyxue
Copy link
Author

zyxue commented Jun 7, 2017

Thanks for the tip. Babili seems promising, but for now, I reimplemented the few functions I needed (matrix transpose and PCA) myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants