Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History Settings #114

Merged
merged 52 commits into from
May 25, 2021
Merged

History Settings #114

merged 52 commits into from
May 25, 2021

Conversation

erinesullivan
Copy link
Collaborator

@erinesullivan erinesullivan commented May 18, 2021 •
edited by niquerio
Loading

Overview

Shows a banner to the user until they have decided on whether or not they wish to have their history saved.

To Do

Text Notifications

Checkout History

  • Show/hide banner based on user settings
  • Update text based on user settings
  • Lightbox view, model, and tests
  • Checkout history form and function

@erinesullivan
Adding and styling banner view
dce06d5
@erinesullivan
Adding form in Settings
bc8396b
@erinesullivan
Updating text in Settings
7fdde16
@erinesullivan
Removing information and adding conditional
f67f81e
@erinesullivan
Updating Settings text
2064e33
@erinesullivan
Merge branch 'main' into history-settings
fd75a90
@erinesullivan
Adding JS to Settings
279866b
@erinesullivan
Merge branch 'main' into history-settings
cd39089
@erinesullivan
Appeasing the newline gods
2069f3a
@erinesullivan
Converting to tel input type
38f4a3c
@erinesullivan
Merge branch 'main' into history-settings
0b6db9d
@erinesullivan @niquerio
Adding and styling banner view
c2b4464
@erinesullivan @niquerio
Adding form in Settings
2ea276b
@erinesullivan @niquerio
Updating text in Settings
bbcea5b
@erinesullivan @niquerio
Removing information and adding conditional
b830a11
@erinesullivan @niquerio
Updating Settings text
85b68a5
@erinesullivan @niquerio
Adding JS to Settings
46e1d05
@erinesullivan @niquerio
Appeasing the newline gods
08b8bad
@erinesullivan @niquerio
Converting to tel input type
6691cdb
@erinesullivan
Merge branch 'history-settings' of github.com:mlibrary/my_account int…
3b35d8b 
…o history-settings
@erinesullivan
Removing JS and splitting up forms
c27e197
@erinesullivan
Removing remove button. Adding toggle styles.
64c3019
@erinesullivan
Adding checkbox value controls
d79f985
@erinesullivan
Checkbox conditional and style updates
5feea27
@erinesullivan
Fixing tests
def15b8
@erinesullivan erinesullivan self-assigned this May 18, 2021
niquerio and others added 15 commits May 18, 2021 21:22
@niquerio
WIP adding circ history image to development docker-compose
d2e357c
@erinesullivan
Adding Checkout History response
228b89b
@erinesullivan
Checking history settings for session patron
1a1e87e
@erinesullivan
Removing requests from checkout history
b1271bb
@erinesullivan
Removing requests from checkout history
8477ef3
@erinesullivan
Merge branch 'main' into history-settings
ab84696
@niquerio
Merge branch 'history-settings' of github.com:mlibrary/patron_account…
b478d8d 
… into history-settings
@erinesullivan
Renaming property
c66afa6
@niquerio
added history settings update route
574793c
@niquerio
Merge branch 'history-settings' of github.com:mlibrary/patron_account…
a358c35 
… into history-settings
@erinesullivan
Removing unused routes/methods
e2fb8be
@erinesullivan
Updating action route
fdb605e
@erinesullivan
Commenting out unused code
7e2ef9e
@niquerio
added docker login for getting circ history image
f650b83
@niquerio
fixed docker-compose.yml; made it so circ history is queryable from host
be7d058
@niquerio niquerio force-pushed the history-settings branch from 7e2ef9e to be7d058 Compare May 24, 2021 19:00
@niquerio niquerio merged commit 31251b2 into main May 25, 2021
@erinesullivan erinesullivan deleted the history-settings branch June 1, 2021 18:59
@erinesullivan erinesullivan linked an issue Jun 25, 2021 that may be closed by this pull request
Show Circ History retention preference in Alma Circ History #52
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erinesullivan erinesullivan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show Circ History retention preference in Alma Circ History
2 participants
@erinesullivan @niquerio