Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Llm large reference #1915

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Llm large reference #1915

wants to merge 13 commits into from

Conversation

pgmpablo157321
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@pgmpablo157321 pgmpablo157321 force-pushed the llm_large_reference branch 2 times, most recently from 3b33ce1 to 7be9b13 Compare November 14, 2024 23:43
v-shobhit
v-shobhit reviewed Nov 15, 2024
View reviewed changes
language/llama3-405b/SUT_VLLM.py
Comment on lines +158 to +160
self.model = LLM(
self.model_path,
dtype=self.dtype,
tensor_parallel_size=self.tensor_parallel_size,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we are not using AsyncLLMEngine here? It may be more efficient since it will support continous batching

@pgmpablo157321 pgmpablo157321 force-pushed the llm_large_reference branch 3 times, most recently from 3fbdbb0 to fe9c189 Compare November 22, 2024 21:08
@pgmpablo157321 pgmpablo157321 marked this pull request as ready for review November 22, 2024 21:08
@pgmpablo157321 pgmpablo157321 requested a review from a team as a code owner November 22, 2024 21:08
@pgmpablo157321 pgmpablo157321 changed the title [WIP] Llm large reference Llm large reference Nov 22, 2024
@pgmpablo157321 pgmpablo157321 force-pushed the llm_large_reference branch 4 times, most recently from f89446b to 7f427a4 Compare November 27, 2024 17:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@v-shobhit v-shobhit v-shobhit left review comments

@tianmu-li tianmu-li tianmu-li left review comments

@nvzhihanj nvzhihanj nvzhihanj left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgmpablo157321 @nvzhihanj @tianmu-li @v-shobhit