Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Change "Label" to "SegmentationMask" for clarity #925

Open
Linardos opened this issue Aug 23, 2024 · 2 comments
Open

[FEATURE] Change "Label" to "SegmentationMask" for clarity #925

Linardos opened this issue Aug 23, 2024 · 2 comments

Comments

@Linardos
Copy link
Contributor

Linardos commented Aug 23, 2024

Is your feature request related to a problem? Please describe.

It gets a bit confusing that GaNDLF uses the word "label" to refer to segmentation. Reason I'm proposing this change is because I spent some time into the code (specifically in the forward_pass.py) where I expected the label_present to refer to classification until I realized it label refers to segmentation in the current GaNDLF version.

Describe the solution you'd like

Instead of Label it would help clarity if instead GaNDLF used the term SegmentationMask both in the csvs and throughout the codebase
I understand the change might run deep but it would make it more intuitive for new users as label is widely associated with classification

@Linardos Linardos changed the title [FEATURE] Change "Label" to "Segmentation_Mask" for clarity [FEATURE] Change "Label" to "SegmentationMask" for clarity Aug 23, 2024
Copy link
Contributor

Stale issue message

@sarthakpati
Copy link
Collaborator

Would anyone be interested to take this on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants