Document correction - update ReactRouter3.md #299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thanks for building such a useful HOC! I know react-router-3 is quite aged and may rarely be used in the community today, but I believe there must still be some who would like to adopt this library to save their life like me. 🙌
The changes are the same as the commit message:
userIsNotAuthenticated
.FYI: The doc on Gitbook needs updates too.
Also here is a proposal, would like to hear how the author and maintainers of this repo think:
I think the name of property
authenticatedSelector
inconnectedRouterRedirect
could be changed to a more neutral one. At the beginning, I misunderstood that the usage ofconnectedRouterRedirect
is only for redirecting not valid/logged-in users to the page for authentication, cuzauthenticatedSelector
makes me think that it implies a "valid" status. I guess the doc's small mistake corrected with this PR was likely caused by a moment of confusion on this too.@mjrussell