-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redirect.js replace UNSAFE_componentWillMount with componentDidMount #266
Comments
Even I am facing same issue? Any timelines to fix this issue? |
Getting the same issue over here. Any possible quick fixes that can be implemented? |
+1 |
Oops misread at first. Why does this need a fix? The behavior is different between the two. Feel free to try a PR but I think you'll find out why its important to use WillMount instead of DidMount |
It's because of this warning when using this library @mjrussell I have a fresh React installation only with this library and started getting this warnings on dev tools.
|
As I said earlier. I'm not sure I can maintain the same behavior/invariants but I welcome a PR that passes the test suite. |
Any reason not to replace UNSAFE_componentWillMount with componentDidMount?
The text was updated successfully, but these errors were encountered: