Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences in code blocks: Border Width and the Scrollbar #115

Open
Phroneris opened this issue Sep 8, 2023 · 2 comments
Open

Differences in code blocks: Border Width and the Scrollbar #115

Phroneris opened this issue Sep 8, 2023 · 2 comments

Comments

@Phroneris
Copy link

Description

In the preview provided by this extension, borders and scrollbars of code blocks are different from those on the actual GitHub.

GitHub's Behavior

Rendering:

.very-long-content {
  content: "very long content very long content very long content very long content very long content very long content very long content very long content very long content very long content";
}

Screenshot:

ext-issue-very-long-content-github

Extension's Behavior

Screenshot:

ext-issue-very-long-content-extension

Difference:

  • One-pixel wide border
  • Scrollbar without buttons at both ends
  • Scrollbar hidden under the bottom rounded corners

While the detailed design of the scrollbar is also up to the browser, the border is clearly different at least.

Specs

@jjspace
Copy link
Contributor

jjspace commented Sep 8, 2023

The border color is showing up because you have the widgets.border color defined in your settings or the theme you are using for VSCode. I just opened a PR to stop using that #116

The scrollbar looks different because VSCode has created a custom one which is also being used inside the markdown preview. There is no way to override or revert a custom scrollbar so unless someone wants to re-implement one that looks close to the default browser one I'm not sure that's something we can address.

@Phroneris
Copy link
Author

Congrats on the PR being merged 🎉

ext-issue-very-long-content-extension-fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@jjspace @Phroneris and others