-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Docker #36
Comments
From @alexisvincent on January 20, 2017 19:23 Awesome :D once this is done let me know and I'll make an automated docker container |
@mjackson Hey! we could do something similar. Just wondering what your thoughts are on how to load default env variables for a standalone server? |
Hey @export-mike :) As I've thought more about this, I think the best route forward would be to build a Docker container that automatically runs everything unpkg needs, including Redis. That would be more portable than a node script and would let people run it on a variety of infrastructures. Some work was done in c714b6b, but I don't know enough about Docker to know if we can use any of that or not. |
@mjackson I’ve worked a lot with docker (since pre 1.0 days) so can offer some guidance here. Having multiple processes running in a container is not ideal, prevents horizontal scaling and means you need to also run a process scheduler inside the container (like systemd). Happy to containerise the project you if the primatives are in place. |
It'd be awesome to have an unpkg docker configuration for people who might want to have their own CDN server over their self-hosted registry. I believe the best way to do it would be to dockerize unpkg alone without Redis and use docker-compose (which allows a multi-container application) to add a redis on top of it. I'm not an expert with Docker nor the architecture of unpkg so I won't be able to help much for making this configuration, but I'd definitely be a user. |
I agree with @tex0l. The containers should only one app (either the web server or the database). docker-compose allows you to easily describe links between containers and allows you to scale any container. |
Has this work been abandoned? What's still outstanding? I can see that you're now using Docker for the dev server. #98 is very compelling for our team, and I'd be happy to help make this happen if it still seems like the best way to make custom registries a reality. |
Any update on this? |
any official versions of this coming? |
From @mjackson on January 19, 2017 18:29
One of the immediately actionable ideas that came out of #65 is to create a standalone development server for unpkg, so people can run it on their own machines. I envision this being a small binary with the following API:
This would launch an HTTP server on the given port that serves packages out of npm. If we also include the index page, it could possibly be used to serve unpkg.com as well.
Copied from original issue: unpkg/express-unpkg#66
The text was updated successfully, but these errors were encountered: