Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize mtime of Makefile.PL/files with mtime in the future #578

Open
Grinnz opened this issue Jul 10, 2018 · 0 comments
Open

Normalize mtime of Makefile.PL/files with mtime in the future #578

Grinnz opened this issue Jul 10, 2018 · 0 comments

Comments

@Grinnz
Copy link

Grinnz commented Jul 10, 2018

For context: https://gist.github.com/Grinnz/c0554c9a373de99cb79a6d19d9d83f2e

As EUMM has logic based on the mtime of the Makefile.PL, issues can be encountered when a machine's clock is further in the past than when the Makefile.PL was generated. One way to fix this scenario is to normalize the mtime (with e.g. touch) of Makefile.PL when extracting if it's in "the future". It may or may not be reasonable to do this for all extracted files. There's also the -m option for tar, but that may not work on all tars and I don't think it's a good idea to normalize mtimes of files that will be installed (plus I bet there are tests depending on the mtime of various files).

I believe this logic would fit in the init_tools function of Menlo::CLI::Compat, https://github.com/miyagawa/cpanminus/blob/devel/Menlo-Legacy/lib/Menlo/CLI/Compat.pm#L2745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant