Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request - Detect loras in prompt and display/insert related keywords in box #26

Open
JoshKasap opened this issue Feb 26, 2023 · 3 comments

Comments

@JoshKasap
Copy link

Using this extension IMHO is very nonintuitive. Ideally, what we all want is a way to easily see and add related keywords for certain loras, models, etc. without needing to remember or look up the keywords online. The way it works currently has a lot of issues that conflict with this vision though.

The issues - From my perspective

  1. You need to manually select from a dropdown what lora you want to use keywords from. This dropdown use text to search so you need to manually scroll and find the lora. If you have 100+ loras this becomes extremely tedious.
  2. After selecting a lora you need to click the keyword dropdown just to see if any were even detected/saved.
  3. keyword selection of dropdown is limited. You can do all keywords, or individual keywords. What if there were only 3 keywords and you only wanted to use 2? The dropdown prevents that
  4. Because keywords are in a dropdown I can copy and past keywords to prompt
  5. Because you need to manually select the lora and keywords using dropdowns, this also means if you had multiple loras you can only use keywords from one at a time in your prompt
  6. Keywords added are added to the beginning of the prompt, but users might not always want them put there.

The solution

I think instead this detection should detect loras that exist in the prompt and show a list of keywords that can be used with each lora. Then the user can click to add whatever keywords they want from the list or lists (if multiple loras are used.)

I imagine this working very similarly to the way adding loras in webui works already. you could have a button that shows and hides the box of keywords. It should probably be positioned just under the prompt box since it will be adding keywords to the prompt.

It's a decent overhaul but i think it would be greatly beneficial.

@mix1009
Copy link
Owner

mix1009 commented Feb 27, 2023

Thank you for the request.
There are some limitation how extension work, so it's not easy to implement as you explained.

  1. Extension can only appear where webui allows it. It's not possible to place the extension right below the prompt box.
  2. Extension only run when user interact with extension's components or user presses the "Generate" button.
  3. I could save the last prompt when generate is pressed and show some kind information when user presses a button. Then the extension could analyze the last prompt and show related information. But I'm not sure users will be comfortable with extension saving your prompt. And the workflow is hard to explain and understand for users.

I think it might be better to make a web service that shows related keywords when you paste your prompt.

@mix1009
Copy link
Owner

mix1009 commented Feb 27, 2023

https://lora-help.coolai.app/

This webpage extracts lora model names from your prompt and returns trigger words for each lora model.

@PaulCoddington
Copy link

Thank you for the request. There are some limitation how extension work, so it's not easy to implement as you explained.

a1111-sd-webui-tagcomplete seems to be able to do what has been requested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants