Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Olli KeyboardManager and Help Modal #84

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Olli KeyboardManager and Help Modal #84

wants to merge 28 commits into from

Conversation

Matt-Blanco
Copy link
Collaborator

Changes

  • Moves the controls of the Tree View to a separate KeyboardManager instead of the previous switch statement
    • The KeyboardManager handles adding new controls and their respective events
    • Has a specific button press to display a help modal containing documentation on each control
  • Add new KeyRegistration and KeyboardAction types to describe each of the controls
  • Adds a description under the root DOM node on how to open the help modal

Appearance

Tree with the help comment:
image

Help modal:
image

@Matt-Blanco Matt-Blanco added documentation Improvements or additions to documentation enhancement New feature or request design exploration Requires prototyping to figure out what's needed labels Jul 10, 2023
@Matt-Blanco Matt-Blanco self-assigned this Jul 10, 2023
@Matt-Blanco Matt-Blanco linked an issue Jul 10, 2023 that may be closed by this pull request
Create a help menu #55
Open
@Matt-Blanco Matt-Blanco removed documentation Improvements or additions to documentation design exploration Requires prototyping to figure out what's needed labels Jul 10, 2023
@Matt-Blanco
Copy link
Collaborator Author

Updated the modal to right align the control descriptions:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanzong jonathanzong Awaiting requested review from jonathanzong

Assignees

@Matt-Blanco Matt-Blanco

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a help menu
1 participant
@Matt-Blanco