Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to HistoricalLayer and usage of BurnMD data #38

Conversation

afennelly-mitre
Copy link
Contributor

Resolves #37.

@afennelly-mitre afennelly-mitre self-assigned this Nov 19, 2024
@afennelly-mitre afennelly-mitre linked an issue Nov 19, 2024 that may be closed by this pull request
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 19, 2024
Copy link

github-actions bot commented Nov 19, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
simfire/game
   game.py1982587%50, 76–80, 250–251, 292–293, 311–315, 344, 346, 348, 353, 356–363, 389, 402–403, 406–407
   image.py19289%20, 31
   sprites.py178697%81, 87, 92, 98, 341, 447
simfire/game/managers
   fire.py204598%223, 265–269, 643, 782
   mitigation.py44198%73
simfire/sim
   simulation.py41912271%73, 83, 93, 103, 113, 129, 140, 150, 170, 181, 324, 416–423, 457–478, 549, 615–628, 648–661, 679, 696, 768, 805–806, 808–809, 839, 858, 871, 892–959, 1020–1024, 1043–1054, 1068–1106
simfire/utils
   config.py50815170%70–83, 112, 224, 239–240, 245–246, 253–254, 270, 284–291, 316–336, 347–354, 367, 405–407, 425–427, 429–431, 450–461, 583, 598, 602, 606, 616–618, 649–700, 719, 730–731, 734, 738, 747–752, 765–773, 794, 800, 804, 814–822, 833, 868–893, 916, 923, 931, 949–973, 1067, 1080, 1103, 1112–1133
   decorators.py13838%15–23
   generate_cfd_wind_layer.py816816%23–32, 36–54, 58–66, 70–80, 86–120
   graph.py67691%107–108, 113, 119, 227, 252
   layers.py46523051%96, 100–101, 148–153, 194, 212, 219, 296–306, 390–399, 402–443, 449–456, 637, 666, 820–852, 857–888, 897–917, 926–930, 947–1042, 1049–1055, 1069–1080, 1092–1101, 1110–1143, 1155–1176, 1195–1203
   log.py321069%11–12, 15–16, 21, 27, 36–38, 41
   terrain.py38879%127–136
   units.py27485%15–16, 29–31
simfire/utils/_tests
   test_layers.py89397%102, 131, 192
simfire/world
   elevation_functions.py24196%100
simfire/world/wind_mechanics
   cfd_wind.py1503974%63–73, 76–95, 130–134, 140–144, 188, 272, 274, 279, 281
   perlin_wind.py35197%42
   wind_controller.py663744%119–146, 157–170, 173, 176, 179, 182, 185
TOTAL387972781% 

Tests Skipped Failures Errors Time
97 0 💤 0 ❌ 0 🔥 2m 22s ⏱️

- Note that in simulation.py, we do 'x, y = fire_pos', so we need to ensure this matches when setting the pos for type == 'historical'!
@afennelly-mitre afennelly-mitre force-pushed the 37-historicallayer-cannot-handle-all-available-burnmd-time-formats branch from 71f7363 to cf929d4 Compare November 19, 2024 21:07
Copy link
Member

@doyled-it doyled-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment I have on fire start location being (y, x) or (x, y)

simfire/utils/config.py Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@doyled-it doyled-it merged commit 04905b1 into main Nov 19, 2024
6 checks passed
@doyled-it doyled-it deleted the 37-historicallayer-cannot-handle-all-available-burnmd-time-formats branch November 19, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HistoricalLayer cannot handle all available BurnMD time formats
2 participants