-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor updates to HistoricalLayer and usage of BurnMD data #38
Merged
doyled-it
merged 5 commits into
main
from
37-historicallayer-cannot-handle-all-available-burnmd-time-formats
Nov 19, 2024
Merged
Minor updates to HistoricalLayer and usage of BurnMD data #38
doyled-it
merged 5 commits into
main
from
37-historicallayer-cannot-handle-all-available-burnmd-time-formats
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Nov 19, 2024
- Note that in simulation.py, we do 'x, y = fire_pos', so we need to ensure this matches when setting the pos for type == 'historical'!
afennelly-mitre
force-pushed
the
37-historicallayer-cannot-handle-all-available-burnmd-time-formats
branch
from
November 19, 2024 21:07
71f7363
to
cf929d4
Compare
doyled-it
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one comment I have on fire start location being (y, x)
or (x, y)
doyled-it
approved these changes
Nov 19, 2024
doyled-it
deleted the
37-historicallayer-cannot-handle-all-available-burnmd-time-formats
branch
November 19, 2024 22:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37.