fix: makes parsec endpoint names scalable; fixes #312 #313
+30
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockett-m
force-pushed
the
parsec-ep-index
branch
from
70de4e2
to
05e54a6
Compare
Signed-off-by: Morgan Rockett <[email protected]>
rockett-m
force-pushed
the
parsec-ep-index
branch
from
05e54a6
to
c94426b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
shard##_endpointAfter:
shard#_#_endpointThis PR let's parsec use the same naming convention as 2pc for shard endpoints.
Also, credit to @madars for pointing out the unnecessary
--shard00_raft_endpoint=$IP:5557.opencbdc-tx/scripts/parsec-run-local.sh
Line 46 in 96062b5
That could be a separate commit or PR based on reviewer discretion