Fixes warnings for sign-compare #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dergoegge
reviewed
Oct 25, 2021
src/batchproof.cpp
Outdated
| @@ -56,7 +56,7 @@ bool BatchProof::Unserialize(const std::vector<uint8_t>& bytes) | |||
| return false; | |||
| } | |||
|
|
|||
| int data_offset = 0; | |||
| uint8_t data_offset = 0; | |||
There was a problem hiding this comment.
Pretty sure this would overflow as an uint8_t while reading the hashes here:
Line 86 in d36b624
There was a problem hiding this comment.
Changed to uint32_t.
Fixes the code so that the sign comparison warnings go away.
kcalvinalvin
force-pushed
the
make-compiler-happy
branch
from
d36b624
to
6da610e
Compare
dergoegge
reviewed
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the code so that the sign comparison warnings go away.