Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): add semi-transparent background to overlay #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phloxic
Copy link
Contributor

@phloxic phloxic commented Jul 8, 2023

  • makes controls visible when current video image is very light
  • shows to user that the entire screen is a temporary controls area
  • color is Video.js primary background color rgb(43, 51, 63) [#2B333F]

- makes controls visible when current video image is very light
- shows to user that the entire screen is a temporary controls area
- color is Video.js primary background color rgb(43, 51, 63) [#2B333F]
@phloxic
Copy link
Contributor Author

phloxic commented Jul 8, 2023

As per #126 (comment)

I also experimented with a background to the widgets only, but found that approach too confusing.

@mister-ben
Copy link
Owner

Thanks, I agree that soemthing's needed to make the button visible on a light background. I'm curious though, what was confusing with background colour on the icons? This is with a background color set in the icon's SVG:

grafik

I think that's less intrusive for the unintentional tap, although if going that route re-using the big play button so the design is consistent might be better...

@phloxic
Copy link
Contributor Author

phloxic commented Aug 1, 2023

The unintentional tap is not introduced by the background-color, really. And the responding area is (currently) larger than the button/svg. My bias may have been influenced the fact that I quite like that the mobile UI is not averse to fat-fingering ;-)

Also I am probably side-tracked by what feels to me like a more important problem: How does the user discover the skip buttons? - Currently only by unintentional tabbing on the left or right, and only when the skip is already happening. So my change could be seen as a half baked attempt to catch 2 flies with 1 stone.

By now it seems to me that a behavior and design like in the youtube mobile app with the previous/next buttons replaced by the skip buttons/behavior would make the most sense: First tap brings up the 3 buttons, user makes choice. Then probably even the skip tooltips would not be needed (in their case I definitely do not like the svg only background color). From my perspective I would then also prefer that the mobile UI looks different than the normal UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants