Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend-embed): 型チェックエラーを修正 #15216

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

samunohito
Copy link
Member

What

(issue切ろうか迷ったけど冗長な気がしたのでそのままprしました)
frontend-embedのpnpm lintで検出できる型エラーを修正します。

#15215 の修正中に見つけたもので、同prが前提になります

Why

Additional info (optional)

  • 型エラーが出なくなることを確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/misskey-js labels Jan 5, 2025
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.69%. Comparing base (3c81926) to head (0cc74c6).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15216      +/-   ##
===========================================
+ Coverage    39.96%   41.69%   +1.73%     
===========================================
  Files         1563     1567       +4     
  Lines       197878   203758    +5880     
  Branches      3646     3733      +87     
===========================================
+ Hits         79080    84955    +5875     
- Misses      118193   118198       +5     
  Partials       605      605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR packages/misskey-js
Projects
Development

Successfully merging this pull request may close these issues.

1 participant