Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: aiscriptディレクトリ内の型エラー解消と単体テスト #15191

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

takejohn
Copy link

What

/packages/frontend/src/scripts/aiscriptディレクトリ内の型エラーを解消し、単体テストを追加します。

Why

#15173 (comment)
まだ一部だけどテスト書いてたら多くなったので一休み

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 95.71429% with 6 lines in your changes missing coverage. Please review.

Project coverage is 20.06%. Comparing base (4120c9a) to head (95fecc6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/scripts/aiscript/ui.ts 95.23% 4 Missing ⚠️
packages/frontend/src/scripts/misskey-api.ts 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15191       +/-   ##
============================================
- Coverage    39.93%   20.06%   -19.88%     
============================================
  Files         1563      729      -834     
  Lines       197977   104047    -93930     
  Branches      3633     1198     -2435     
============================================
- Hits         79065    20874    -58191     
+ Misses      118307    82621    -35686     
+ Partials       605      552       -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takejohn
Copy link
Author

takejohn commented Jan 4, 2025

#15158 で追加されたMk:removeにもテストを追加

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

1 participant