Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): ユーザーページに「ファイル」タブを新設 #15130

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 14, 2024

What

  • ユーザーページに、ノートに使用したファイルを一覧表示できるファイルタブを新設
  • ユーザーページトップの「ファイル」の「もっと見る」を押すとcollapseが解除されるのではなくファイルタブに飛ぶように
  • コンポーネント統一の過程で以下を修正

image

Why

Fix #13702
Fix #12359
Fix #10241

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 20.09346% with 171 lines in your changes missing coverage. Please review.

Project coverage is 19.26%. Comparing base (4120c9a) to head (138b421).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ckages/frontend/src/components/MkNoteMediaGrid.vue 0.00% 98 Missing and 1 partial ⚠️
packages/frontend/src/pages/user/files.vue 0.00% 55 Missing and 1 partial ⚠️
packages/frontend/src/components/MkContainer.vue 0.00% 9 Missing ⚠️
packages/frontend/src/pages/user/index.vue 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15130       +/-   ##
============================================
- Coverage    39.93%   19.26%   -20.67%     
============================================
  Files         1563      730      -833     
  Lines       197977   104132    -93845     
  Branches      3633      993     -2640     
============================================
- Hits         79065    20065    -59000     
+ Misses      118307    83511    -34796     
+ Partials       605      556       -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft December 16, 2024 00:00
@kakkokari-gtyih
Copy link
Contributor Author

MkDriveFileThumbnailに統一できそう

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review December 16, 2024 00:25
@kakkokari-gtyih
Copy link
Contributor Author

した

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
3 participants