Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Remove undefined style #14427

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Aug 17, 2024

What

MkPreview 内の未定義なスタイルを削除します。

Why

ビルドするときに出る次の警告を解決したい:

Undefined style detected: $style.preview__content1 (in MkSample)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 17, 2024
@kakkokari-gtyih kakkokari-gtyih merged commit ba9c5c3 into misskey-dev:develop Aug 17, 2024
17 checks passed
@kakkokari-gtyih
Copy link
Contributor

🙏

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 20.15%. Comparing base (75b0315) to head (18b606c).
Report is 14 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/components/MkPreview.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14427       +/-   ##
============================================
- Coverage    39.90%   20.15%   -19.76%     
============================================
  Files         1547      725      -822     
  Lines       190875   100466    -90409     
  Branches      3569     1051     -2518     
============================================
- Hits         76166    20247    -55919     
+ Misses      114116    79676    -34440     
+ Partials       593      543       -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woxtu woxtu deleted the preview branch August 18, 2024 08:27
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants