fix: #13368 最優先されるフォントをSegoe UIとHelveticaNeueにする #13390
Open
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/frontend
morotesovtannu
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13390 +/- ##
===========================================
- Coverage 64.48% 64.46% -0.02%
===========================================
Files 981 981
Lines 109999 109999
Branches 5605 5593 -12
===========================================
- Hits 70937 70915 -22
- Misses 37628 37650 +22
Partials 1434 1434 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら |
|
謎 |
|
|
|
|
|
Allow edits and access to secrets by maintainersが無効になっているPRできないようにできないかしら |
|
単にカスタムCSSで指定しただけですが、Mac環境の参考までにどうぞ Before
After
|
|
うーん日本語文脈においては全角表示が正しいわけで, 言語設定依存で変えるべしな気がする |
ほんまか？ |
|
off-topic（そうでなくとも、言語設定依存で変えられるようになればCJKの漢字の重複してるところとかも言語別でよしなに指定できるようになってよさそうではある） |
|
これiOSで日本語を表示するとどうなるか知りたい |
一旦こっちで実装できるかやってみる（swのフォールバックはそういう機構をもたせると複雑化するからこの実装で問題ないと思われ） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
優先するフォントを日本語フォントから欧文フォントに変更。
Vivaldi Snapshot(Windows 11)での変更結果は以下の通り。
Before
After
Why
現行の日本語フォントを優先する設定だと、キリル文字がすべて全角で表示されてしまうため。
#13368
Additional info (optional)
HelveticaNeueをMac向けに優先させたが、現状Macでのテストは環境が無いためできていない。
fix #13368
Checklist