fix(backend): We can renote pure renote #12171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12171 +/- ##
===========================================
- Coverage 79.13% 78.88% -0.25%
===========================================
Files 940 175 -765
Lines 100957 22946 -78011
Branches 8217 493 -7724
===========================================
- Hits 79894 18102 -61792
+ Misses 21063 4844 -16219 ☔ View full report in Codecov by Sentry. |
anatawa12
commented
Oct 28, 2023
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -1,7 +1,7 @@
{
"openapi": "3.0.0",
"info": {
- "version": "2023.11.0-beta.6",
+ "version": "2023.11.0-beta.5",
"title": "Misskey API",
"x-logo": {
"url": "/static-assets/api-doc.png" |
anatawa12
force-pushed
the
we-can-renote-renote
branch
from
6352927 to
e13194f
Compare
anatawa12
changed the title
|
👍🏻 |
kanarikanaru
pushed a commit
to kanarikanaru/misskey
that referenced
this pull request
Nov 2, 2023
* chore: make pure renote detection an function * fix: we can renote pure renote * docs(changelog): リノートをリノートできるのを修正 * fix: remaining debug log * chore: move isPureRenote to misc * chore: make isPureRenote type guard * chore: use isPureRenote in other places * fix CHANGELOG * style: fix lint --------- Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix #12170
Why
Additional info (optional)
そもそもpure RN判定が壊れてたっぽいのと同用途のコードがあったので関数にした
Checklist