Fix enum name processing and add uppercase flag #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bugs in the processing of enum names:
DESC_NULLS_LAST
was being converted intoLAST
process_name
and so could not be hooked into the plugin customization pipelineconvert_to_snake_case
optionThis PR additionally adds the
convert_enums_names_to_upper_snake_case
option to convert enum members to upper snake case like:I think this should be a core option rather than a plugin since it is more idiomatic. It also avoid enum name conflicts. For instance I had an enum with
title
andname
as members, which conflicted with the built-in enum methods of the same name. I set the flag to default False for backwards compat.