Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up node references #77

Open
g2p opened this issue Mar 29, 2019 · 0 comments
Open

Clean up node references #77

g2p opened this issue Mar 29, 2019 · 0 comments

Comments

@g2p
Copy link
Collaborator

g2p commented Mar 29, 2019

First order of business is to remove insertable from the public interface.

add_child should then be reimplemented in terms of fast_insert + InsChild (fast_insert can do more checks, and using the same interface would allow spilling through fast_insert).

Then we get into the question of children vs child_alloc_id semantics. Currently these are made complex due to path dependence. We could simplify these by storing a sum type which is either a loc or an alloc_id, similar to how it was done on raw_node, but with an explicit discriminant.
flush_children will stay separate, because it is (most likely) a much smaller tree.

g2p added a commit to g2p/wodan that referenced this issue Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant