-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure market-cap repo to avoid index.ts
conflict
#182
Comments
We were noticing the same, not sure how smooth JS can handle integration of a "loose bunch" of JS files :) We do also rely on some way to easily assess all tracked tokens, i.e. if a map is generated on the fly that holds as keys all the tokens that are tracked thats perfect for us. |
Currently we don't use npm library anymore, we just pull the latest commit and run if you still want npm package, I can extend the build process to generate |
An autogenerated ´index.ts´ sounds good - after all the structure of the file is really straightforward. |
If the structure is being changed as is, why not change token entries in /src/tokens/ to be .json files with a set structure to make it more accessible (and less prone to errors) for projects to modify these files? Feels like a import all .json files on the tokens folder would do the job, with a simple structure that takes care of all variables. |
yeah I'm also thinking about that but afraid that we can't accomodate to all projects' need, maybe a project has an adhoc formula |
Currently
index.ts
get conflicted a lot if we don't merge PRs for a while because everyone is updating itMaybe we can refactor to like
cardano-token-registry
where each token is a file with itspolicyId + assetName
be the file name, and the file will export default the fetcherWDYT @MuesliSwapTeam @TheTapHouse @shadowkora
The text was updated successfully, but these errors were encountered: