From 28d5b1854c920ad2d4f4b8bf827833a37b7c8cd0 Mon Sep 17 00:00:00 2001
From: farrell-m <168534673+farrell-m@users.noreply.github.com>
Date: Wed, 18 Sep 2024 09:47:02 +0100
Subject: [PATCH] update ecr secrets (#50)

---
 .github/workflows/on-tag.yml | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/on-tag.yml b/.github/workflows/on-tag.yml
index a63671b..6b090b6 100644
--- a/.github/workflows/on-tag.yml
+++ b/.github/workflows/on-tag.yml
@@ -79,7 +79,6 @@ jobs:
           path: caab-service/build/libs/caab-service-${{ steps.capture_version.outputs.app_version }}.jar
 
   ecr:
-    environment: development
     needs: [build-test-publish, define-image-tag]
     runs-on: ubuntu-latest
     permissions:
@@ -97,8 +96,8 @@ jobs:
       - name: Configure aws credentials
         uses: aws-actions/configure-aws-credentials@v2
         with:
-          role-to-assume: ${{ secrets.DEV_ECR_ROLE_TO_ASSUME }}
-          aws-region: ${{ vars.DEV_ECR_REGION }}
+          role-to-assume: ${{ secrets.ECR_ROLE_TO_ASSUME }}
+          aws-region: ${{ vars.ECR_REGION }}
 
       - name: Login ecr
         uses: aws-actions/amazon-ecr-login@v1
@@ -108,7 +107,7 @@ jobs:
       - name: docker build and push
         env:
           REGISTRY: ${{ steps.login-ecr.outputs.registry }}
-          REPOSITORY: ${{ vars.DEV_ECR_REPOSITORY }}
+          REPOSITORY: ${{ vars.ECR_REPOSITORY }}
           REPO_NAME: ${{ needs.define-image-tag.outputs.repo_name }}
           APP_VERSION: ${{ needs.build-test-publish.outputs.app_version }}
         run: |
@@ -124,7 +123,6 @@ jobs:
   update-helm-chart:
     needs: [ build-test-publish, ecr, define-image-tag ]
     runs-on: ubuntu-latest
-    environment: development
     steps:
       - name: Checkout charts repo
         uses: actions/checkout@v3
@@ -150,7 +148,6 @@ jobs:
   update-laa-ccms-caab-ui:
     needs: [ build-test-publish, define-image-tag ]
     runs-on: ubuntu-latest
-    environment: development
     steps:
       - name: Checkout caab-ui repo
         uses: actions/checkout@v3