Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make mesechest more reliable #35

Merged
merged 4 commits into from
Apr 30, 2024
Merged

make mesechest more reliable #35

merged 4 commits into from
Apr 30, 2024

Conversation

a-tour-ist
Copy link
Contributor

Like the title says. The current hack to get on the on_player_receive_fields function is quite likely to break with instrumented code.

While being in there, I also changed the workaround to get custom inventory callbacks for the chest from overriding minetest.register_node to the usage of minetest.override_item

@a-tour-ist
Copy link
Contributor Author

Thanks, updated it.

@SmallJoker
Copy link
Member

Looks good. Will merge in a few days unless there are objections.

@SmallJoker SmallJoker merged commit 9338418 into minetest-mods:master Apr 30, 2024
1 check passed
@a-tour-ist a-tour-ist deleted the mesechest-fix branch April 30, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-tour-ist @SmallJoker