Fixed a potential "none dereference" if redirect url is absent for HT…

…TP redirect codes.
mindstorm38 · Apr 21, 2024 · ae6e9be · ae6e9be
1 parent 4368a8e
commit ae6e9be
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/portablemc/download.py b/portablemc/download.py
@@ -330,17 +330,18 @@ def _download_thread(
                         pass
 
                     if res.status == 301 or res.status == 302:
-
-                        redirect_url = res.headers["location"]
-                        redirect_entry = DownloadEntry(
-                            redirect_url, 
-                            entry.dst, 
-                            size=entry.size, 
-                            sha1=entry.sha1, 
-                            name=entry.name)
-
-                        entries_queue.put(_DownloadEntry.from_entry(redirect_entry))
-                        break  # Abort on redirect
+                        # If location header is absent, consider it not found.
+                        redirect_url = res.headers.get("location")
+                        if redirect_url is not None:
+                            redirect_entry = DownloadEntry(
+                                redirect_url, 
+                                entry.dst, 
+                                size=entry.size, 
+                                sha1=entry.sha1, 
+                                name=entry.name)
+
+                            entries_queue.put(_DownloadEntry.from_entry(redirect_entry))
+                            break  # Abort on redirect
 
                     # Any other non-200 code is considered not found and we retry...
                     last_error = DownloadResultError.NOT_FOUND