Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing auth login command due to missing credentials #5031

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

rdimitrov
Copy link
Member

Summary

The following PR fixes the auth login command which was failing every time one logs in.

This was caused by the fact that we were passing a gRPC connection through the wrapper which did not had the credentials embedded in it (the login step happens after that). The fix is to ignore the conn from the wrapper and recreate it after the login step is completed. This way the credentials are properly loaded.

Fixes: #4988

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner November 23, 2024 01:15
@rdimitrov rdimitrov self-assigned this Nov 23, 2024
@coveralls
Copy link

Coverage Status

coverage: 54.515% (-0.007%) from 54.522%
when pulling 840fea4 on fix-login
into 8b25d8c on main.

@JAORMX JAORMX merged commit 613030b into main Nov 25, 2024
25 of 26 checks passed
@JAORMX JAORMX deleted the fix-login branch November 25, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First login from CLI states that user is logged out
4 participants