Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: make runtime config into a global environment table #38671

Merged
merged 2 commits into from
Dec 24, 2024
Merged

enhance: make runtime config into a global environment table #38671

merged 2 commits into from
Dec 24, 2024
+51 −73

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 23, 2024

issue: #38399

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 23, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (6884319) to head (a32460f).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38671       +/-   ##
===========================================
+ Coverage   69.33%   81.05%   +11.71%     
===========================================
  Files         292     1380     +1088     
  Lines       26187   195133   +168946     
===========================================
+ Hits        18158   158162   +140004     
- Misses       8029    31392    +23363     
- Partials        0     5579     +5579
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.33% <ø> (ø)
Go 83.03% <100.00%> (∅)
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.38% <ø> (ø)
pkg/util/paramtable/param_item.go 83.33% <ø> (ø)
pkg/util/paramtable/runtime.go 85.71% <100.00%> (ø)

... and 1085 files with indirect coverage changes

@chyezh
Copy link
Contributor Author

chyezh commented Dec 23, 2024

rerun go-sdk

@chyezh
fix: add unittest
a32460f 
Signed-off-by: chyezh <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 23, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Dec 24, 2024

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 24, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Dec 24, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 24, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 118678b into milvus-io:master Dec 24, 2024
20 checks passed
@chyezh chyezh deleted the enhance_move_runtime_config_out_of_param branch December 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@jaime0815 jaime0815

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chyezh @sre-ci-robot @jaime0815