From db5f4916cf1ed1e3711d5897d0c7c3d2b54c5c06 Mon Sep 17 00:00:00 2001 From: "xianliang.li" Date: Thu, 14 Nov 2024 18:23:41 +0800 Subject: [PATCH] update knowhere version Signed-off-by: xianliang.li --- internal/core/thirdparty/knowhere/CMakeLists.txt | 2 +- internal/proxy/task_test.go | 4 ++-- tests/python_client/conftest.py | 1 - 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/internal/core/thirdparty/knowhere/CMakeLists.txt b/internal/core/thirdparty/knowhere/CMakeLists.txt index 1fb371906f418..fa6b23f1e5380 100644 --- a/internal/core/thirdparty/knowhere/CMakeLists.txt +++ b/internal/core/thirdparty/knowhere/CMakeLists.txt @@ -14,7 +14,7 @@ # Update KNOWHERE_VERSION for the first occurrence milvus_add_pkg_config("knowhere") set_property(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES "") -set( KNOWHERE_VERSION 5935c1f ) +set( KNOWHERE_VERSION d3605fb ) set( GIT_REPOSITORY "https://github.com/zilliztech/knowhere.git") message(STATUS "Knowhere repo: ${GIT_REPOSITORY}") message(STATUS "Knowhere version: ${KNOWHERE_VERSION}") diff --git a/internal/proxy/task_test.go b/internal/proxy/task_test.go index 147c7e8b3a7aa..242acffb909fb 100644 --- a/internal/proxy/task_test.go +++ b/internal/proxy/task_test.go @@ -2369,7 +2369,7 @@ func Test_checkTrain(t *testing.T) { assert.Error(t, checkTrain(f, m)) }) - t.Run("invalid params", func(t *testing.T) { + t.Run("nlist test", func(t *testing.T) { f := &schemapb.FieldSchema{ DataType: schemapb.DataType_FloatVector, IndexParams: []*commonpb.KeyValuePair{ @@ -2383,7 +2383,7 @@ func Test_checkTrain(t *testing.T) { common.IndexTypeKey: "IVF_FLAT", common.MetricTypeKey: "L2", } - assert.Error(t, checkTrain(f, m)) + assert.NoError(t, checkTrain(f, m)) }) } diff --git a/tests/python_client/conftest.py b/tests/python_client/conftest.py index b88ad7d8d7ae9..04a03dc71072f 100644 --- a/tests/python_client/conftest.py +++ b/tests/python_client/conftest.py @@ -241,7 +241,6 @@ def get_index_param(request): # TODO: construct invalid index params for all index types @pytest.fixture(params=[{"metric_type": "L3", "index_type": "IVF_FLAT"}, - {"metric_type": "L2", "index_type": "IVF_FLAT", "err_params": {"nlist": 10}}, {"metric_type": "L2", "index_type": "IVF_FLAT", "params": {"nlist": -1}}]) def get_invalid_index_params(request): yield request.param