Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bitmap index large size cause panic error #38796

Closed
wants to merge 4 commits into from

Conversation

982945902
Copy link

about croaring getSizeInBytes describe

image

default sue compact serialize version.
bitmap index when Cardinality is large GetIndexDataSize will get very large size cause alloc failed exception.
in our case ,the bitmap index cardinality is 53583500, GetIndexDataSize will return 18446744071658782694. when use getSizeInBytes(false) that GetIndexDataSize will return 1794992794.
so i suggest use getSizeInBytes(false) !

@sre-ci-robot
Copy link
Contributor

Welcome @982945902! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 982945902
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@982945902 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@982945902

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@mergify mergify bot added needs-dco DCO is missing in this pull request. do-not-merge/invalid-pr-format labels Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@982945902 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@982945902 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@982945902 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 27, 2024

@982945902 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 27, 2024

@982945902 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (4df444e) to head (b7c2428).
Report is 6 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4df444e) and HEAD (b7c2428). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4df444e) HEAD (b7c2428)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38796       +/-   ##
===========================================
- Coverage   81.09%   69.45%   -11.64%     
===========================================
  Files        1383      294     -1089     
  Lines      195636    26429   -169207     
===========================================
- Hits       158642    18357   -140285     
+ Misses      31404     8072    -23332     
+ Partials     5590        0     -5590     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.45% <100.00%> (+0.01%) ⬆️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/index/BitmapIndex.cpp 81.00% <100.00%> (ø)

... and 1092 files with indirect coverage changes

@982945902 982945902 closed this Dec 27, 2024
@982945902 982945902 reopened this Dec 27, 2024
@982945902 982945902 closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/invalid-pr-format needs-dco DCO is missing in this pull request. size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants