-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bitmap index large size cause panic error #38796
Conversation
…rge size cause alloc throw
Welcome @982945902! It looks like this is your first PR to milvus-io/milvus 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 982945902 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@982945902 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@982945902 cpp-unit-test check failed, comment |
@982945902 go-sdk check failed, comment |
@982945902 E2e jenkins job failed, comment |
…rge size cause alloc throw
…rge size cause alloc throw
@982945902 go-sdk check failed, comment |
@982945902 E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38796 +/- ##
===========================================
- Coverage 81.09% 69.45% -11.64%
===========================================
Files 1383 294 -1089
Lines 195636 26429 -169207
===========================================
- Hits 158642 18357 -140285
+ Misses 31404 8072 -23332
+ Partials 5590 0 -5590
|
…rge size cause alloc throw
about croaring getSizeInBytes describe
default sue compact serialize version.
bitmap index when Cardinality is large GetIndexDataSize will get very large size cause alloc failed exception.
in our case ,the bitmap index cardinality is 53583500, GetIndexDataSize will return 18446744071658782694. when use getSizeInBytes(false) that GetIndexDataSize will return 1794992794.
so i suggest use getSizeInBytes(false) !