Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [GoSDK] Add APIs for backup tool #38791

Merged
merged 3 commits into from
Dec 27, 2024
Merged

enhance: [GoSDK] Add APIs for backup tool #38791

merged 3 commits into from
Dec 27, 2024
+541 −11

Conversation

congqixia
Copy link
Contributor

Related to #31291

This PR:

  • Add Backup&Restore RBAC APIs
  • Add GetPersistentSegmentInfo API
  • Add GetServerVersion API
  • Add flush task stats

@congqixia
enhance: [GoSDK] Add APIs for backup tool
4fc66e7 
Related to milvus-io#31291

This PR:

- Add Backup&Restore RBAC APIs
- Add GetPersistentSegmentInfo API
- Add GetServerVersion API
- Add flush task stats

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. approved labels Dec 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Fix lint
c78cc83 
Signed-off-by: Congqi Xia <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.12230% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.04%. Comparing base (4df444e) to head (f86e9e5).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
client/entity/segment.go 0.00% 2 Missing ⚠️
client/milvusclient/maintenance.go 77.77% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38791      +/-   ##
==========================================
- Coverage   81.09%   79.04%   -2.05%     
==========================================
  Files        1383     1377       -6     
  Lines      195636   194529    -1107     
==========================================
- Hits       158642   153766    -4876     
- Misses      31404    35209    +3805     
+ Partials     5590     5554      -36
Components Coverage Δ
Client 78.73% <97.12%> (+0.47%) ⬆️
Core 69.43% <ø> (ø)
Go 80.61% <ø> (-2.47%) ⬇️
Files with missing lines Coverage Δ
client/milvusclient/admin.go 100.00% <100.00%> (ø)
client/entity/segment.go 0.00% <0.00%> (ø)
client/milvusclient/maintenance.go 88.78% <77.77%> (-0.78%) ⬇️

... and 250 files with indirect coverage changes

@congqixia
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 27, 2024
ThreadDao
ThreadDao reviewed Dec 27, 2024
View reviewed changes
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit a882f34 into milvus-io:master Dec 27, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThreadDao ThreadDao ThreadDao left review comments

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees

@ThreadDao ThreadDao

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @ThreadDao