Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Initialize field id to avoid negative number #38789

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Dec 26, 2024

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Dec 26, 2024

rerun go-sdk

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.09%. Comparing base (a882f34) to head (77dc3ed).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38789      +/-   ##
==========================================
- Coverage   82.93%   81.09%   -1.85%     
==========================================
  Files        1091     1385     +294     
  Lines      169357   195822   +26465     
==========================================
+ Hits       140453   158797   +18344     
- Misses      23319    31417    +8098     
- Partials     5585     5608      +23     
Components Coverage Δ
Client 78.73% <ø> (ø)
Core 69.45% <ø> (∅)
Go 83.06% <82.53%> (-0.03%) ⬇️

see 328 files with indirect coverage changes

@sunby
Copy link
Contributor Author

sunby commented Dec 27, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 27, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Dec 27, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 27, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2557e3f into milvus-io:master Dec 27, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants