Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: speed up streaming barrier timetick #38787

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 26, 2024

issue: #38399

  • use last allocate but not last confirmed id to make barrier.
  • move the barrier logic into the timetick allocator.
  • try to sync up local allocator and remote allocator when first barrier check not pass to speed up.

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Dec 26, 2024

rerun cpp-unit-test

@bigsheeper
Copy link
Contributor

/lgtm

Copy link
Contributor

mergify bot commented Dec 26, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Dec 26, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Dec 26, 2024

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Dec 26, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the enhance_speed_up_barrier_timetick branch from 64e8299 to b4cfdfa Compare December 26, 2024 13:34
@sre-ci-robot sre-ci-robot removed the lgtm label Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 82.53968% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (f49d618) to head (b4cfdfa).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...streamingnode/server/resource/idalloc/allocator.go 83.01% 6 Missing and 3 partials ⚠️
...de/server/wal/interceptors/timetick/ack/manager.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38787      +/-   ##
==========================================
+ Coverage   81.08%   81.10%   +0.02%     
==========================================
  Files        1381     1383       +2     
  Lines      195289   195672     +383     
==========================================
+ Hits       158345   158699     +354     
- Misses      31354    31381      +27     
- Partials     5590     5592       +2     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.43% <ø> (+0.11%) ⬆️
Go 83.09% <82.53%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
...ingnode/server/resource/idalloc/basic_allocator.go 83.72% <ø> (ø)
...de/server/wal/interceptors/timetick/ack/manager.go 96.62% <80.00%> (-0.25%) ⬇️
...streamingnode/server/resource/idalloc/allocator.go 89.65% <83.01%> (-10.35%) ⬇️

... and 42 files with indirect coverage changes

@chyezh
Copy link
Contributor Author

chyezh commented Dec 27, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 27, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Dec 27, 2024

rerun go-sdk

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815
Copy link
Contributor

/lgtm

@mergify mergify bot added the ci-passed label Dec 27, 2024
@sre-ci-robot sre-ci-robot merged commit 4ba0ed3 into milvus-io:master Dec 27, 2024
20 checks passed
@chyezh chyezh deleted the enhance_speed_up_barrier_timetick branch December 27, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants