Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Revert clean compaction task in compactionHandler #38753

Conversation

xiaocai2333
Copy link
Contributor

Reverts #38584

issue: #35711

master pr: #38170

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Dec 25, 2024
Copy link
Contributor

mergify bot commented Dec 25, 2024

@xiaocai2333 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/enhancement Issues or changes related to enhancement labels Dec 25, 2024
@xiaocai2333 xiaocai2333 changed the title enhance: Revert "enhance: [2.4] clean compaction task in compactionHandler (#38170)" enhance: [2.4] clean compaction task in compactionHandler Dec 25, 2024
@xiaocai2333 xiaocai2333 changed the title enhance: [2.4] clean compaction task in compactionHandler enhance: [2.4] revert clean compaction task in compactionHandler Dec 25, 2024
@xiaocai2333 xiaocai2333 force-pushed the revert-38584-clean_compaction_task_pick branch from f7ba5f7 to d403cc6 Compare December 25, 2024 11:28
@xiaocai2333 xiaocai2333 changed the title enhance: [2.4] revert clean compaction task in compactionHandler enhance: [2.4] Revert clean compaction task in compactionHandler Dec 25, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Dec 25, 2024
Copy link
Contributor

mergify bot commented Dec 25, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Dec 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 50 lines in your changes missing coverage. Please review.

Project coverage is 72.14%. Comparing base (b9eb396) to head (d403cc6).
Report is 2 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datacoord/compaction_task_clustering.go 51.47% 29 Missing and 4 partials ⚠️
internal/datacoord/compaction_task_mix.go 0.00% 13 Missing ⚠️
internal/datacoord/compaction_task_l0.go 80.00% 2 Missing ⚠️
internal/datacoord/partition_stats_meta.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38753      +/-   ##
==========================================
- Coverage   80.40%   72.14%   -8.26%     
==========================================
  Files        1077     1077              
  Lines      169610   169507     -103     
==========================================
- Hits       136369   122289   -14080     
- Misses      28744    42730   +13986     
+ Partials     4497     4488       -9     
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 74.86% <100.00%> (-2.86%) ⬇️
internal/datacoord/compaction_task.go 88.88% <ø> (ø)
internal/datacoord/meta.go 88.24% <ø> (-1.62%) ⬇️
pkg/util/merr/errors.go 92.18% <ø> (ø)
pkg/util/merr/utils.go 83.15% <ø> (-0.13%) ⬇️
internal/datacoord/compaction_task_l0.go 95.23% <80.00%> (+1.14%) ⬆️
internal/datacoord/partition_stats_meta.go 43.62% <33.33%> (-8.50%) ⬇️
internal/datacoord/compaction_task_mix.go 57.03% <0.00%> (-3.96%) ⬇️
internal/datacoord/compaction_task_clustering.go 72.55% <51.47%> (-6.46%) ⬇️

... and 227 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 25, 2024
@xiaocai2333 xiaocai2333 added this to the 2.4.19 milestone Dec 25, 2024
@sre-ci-robot sre-ci-robot merged commit e8eea58 into milvus-io:2.4 Dec 25, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants